On Thursday 20 November 2014 10:43:11 Darshit Shah wrote: > On 11/19, Daniel Stenberg wrote: > >On Wed, 19 Nov 2014, Tim Rühsen wrote: > >>I won't change my toolchain just to see these formfeeds. Looks like > >>I had luck so far... but now, really, how can I work on Wget's > >>sources from now on ? I have to stop here and now... > > > >Stop with that crap (formfeed characters) already. Exactly zero people > >actually need those things in source code, which is also why no modern > >projects use them anywhere. They're not helpful these days. > > > >Also, the GNU code guidelines say this[1]: "Please use formfeed > >characters (control-L) to divide the program into pages at logical > >places". It does not say that they are mandatory or that you'll be run > >out of the village if you don't use them. > > > >Code guidelines are supposed to *help*! > > > >[1] = end of the section at > >http://www.gnu.org/prep/standards/standards.html#Formatting > > I completely agree that we do not need (or want) those form feed characters > in the code. And the whole issue erupted because the patch had some changes > on the same line as a form feed character. Let's just amend it and move on > for now. > > It would seem that GNU Emacs has a mode where it can use these linefeed > characters to browse the source by pages. I think when a project is already > placing logically separate parts of the code in different files, we > shouldn't be logically separating a single file with line feed characters. > > @Tim: Please just add that include statement one line above, or else I'll > make the required change and push it.
Made the change using vi and pushed it. @Darshit Sorry for yesterdays comments regarding formfeed. I was really pissed, but nothing personal (it was this whole formfeed thing and having no chance to make it visible in my IDE). @Daniel I would like to hug you for your answer ;-) Tim
signature.asc
Description: This is a digitally signed message part.
