Patches look good. Except the last one may still not have the right commit message format.
However, we are enforcing a feature freeze for now till the next release. Once there, we can merge these patches. On Sat, Jan 31, 2015 at 7:43 AM, Yousong Zhou <[email protected]> wrote: > On 31 January 2015 at 07:53, Giuseppe Scrivano <[email protected]> wrote: >> Yousong Zhou <[email protected]> writes: >> >>> On 29 January 2015 at 21:26, Tim Ruehsen <[email protected]> wrote: >>>> Hi Yousong, >>>> >>>>> > this patch seems to be incomplete. Do you have a complete patch (e.g. >>>>> > +new >>>>> > option, + docs) or are you going to work on it ? >>>>> >>>>> That patch was only intended as a ephemeral one to see if it can solve >>>>> the issue reported by Joe at the time. But checking it again, I now >>>>> think the patch actually does the right thing. The reason is that >>>>> since those --content-on-error pages are downloaded, then links within >>>>> those pages should be converted as specified by --convert-links. >>>>> There is no need for a new option for this and the current doc is just >>>>> fine. But I will try adding an test cases for this. >>>> >>>> Ah sorry, my fault / misunderstanding. >>>> Since the patch changes Wget behaviour I would apply it after the next >>>> bugfix >>>> release. >>>> A test case would be perfect. Please consider creating a python test case >>>> (see >>>> directory testenv). We will move all test cases from perl to python by the >>>> time. >>>> >>> >>> Well, there they are, with a few fixes for other issues I encountered >>> when preparing for this. >> >> patches look fine to me, could you please ensure to write the commit >> message using the ChangeLog format? >> >> When it is just one line log, you can just use the format: >> >> * blah/file (function): Describe what changed. >> >> Otherwise use the format: >> >> one short line to describe the change >> >> * blah/file1 (foo): Describe what changed here. >> * blah/file2 (bar): And here. >> >> More about the ChangeLog style here: >> >> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs >> > > Changes are made to > > - Follow GNU Changelog style commit message. > - Update the 2nd patch so that no color codes will be printed when > the stdout is not a tty-like device. > > > yousong > >> Thanks, >> Giuseppe -- Thanking You, Darshit Shah
