Hi Satyam,
I have modified the Test file according to suggestions I have got from mentors .
The patch looks good now.However, when you're sending an updated version of your patch which isn't yet merged into the repository, please consider sending the entire patch instead of a diff against the last version.
There is a very high chance that master and your last version will have diverged and your previous patches won't apply cleanly. This will cause quite a few problems for everyone trying to test your patch.
As Darshit and Tim has suggested me modifications line by line , I have tried to solve them .
Great! Though let me nitpick here. Why have you added a couple of new empty lines to the patch? This is pure aesthetic nitpicking and ignore it if you like.
I think I should move on to main task about project though I have started looking at it . I want to focus on proposal and main project as Darshit has mentioned in the previous mail . Please suggest me rough sketch of FTP test suite project . Things I know are 1) Implementation of FTP server . 2) Tests for FTP server .
This really is a topic for a different thread.
If I am missing anything else please point it out .
We'll begin merging your patches once you complete the FSF Copyright Assignments.
-- Thanking You, Darshit Shah
pgpP01uN78ZIl.pgp
Description: PGP signature
