On Tuesday 21 April 2015 08:29:51 Ander Juaristi wrote: > On 04/20/2015 04:59 PM, Tim Ruehsen wrote: > > Hi Ander, > > > > sorry to answer so late. I was waiting for the mentioned test case... ;-) > > Indeed, I had scheduled it for Monday (yesterday) in my messy mental agenda > :D So here it goes. My apologies if you had expected it earlier.
Cool !
Just these two little things :-)
Could you please add the test to testenv/Makefile.am !?
And please shorten the first line of the commit message to max. 72 chars.
You could (optionally) add some description in a third paragraph. E.g.
##########
First commit message line
testenv/Test--reserved-chars.py: Add new test
testenv/Makefile.am: Add Test--reserved-chars.py
Detailed description what the test does incl. reference
to RFC 3987 3.2.
##########
About the warnings that you won't get:
I add a .cflags into each project, containing project dependent flags like
e.g.
export CFLAGS="..."
When switching projects, I do
. .cflags
before ./configure
For Wget I currently use
export CFLAGS="-std=c89 -pedantic -O2 -g -Wall -Wextra -Wstrict-prototypes -
Wold-style-definition -Wwrite-strings -Wshadow -Wformat -Wformat-security -
Wunreachable-code -Wstrict-prototypes -Wmissing-prototypes -Wold-style-
definition -Wlogical-op -D_FORTIFY_SOURCE=2 -D _GNU_SOURCE"
Regards, Tim
signature.asc
Description: This is a digitally signed message part.
