Hi Ander, many thanks for working so hard and steady on FTPS support.
I tested and finally pushed your patch to master. @Darshit Any news about FTPS test server support ? Best regards, Tim On Saturday 12 September 2015 01:58:57 Ander Juaristi wrote: > Hi, > > I merged your first patch on top of mine and it all works well now. It > also passes all the tests. I also removed old code that appeared in my > previous patch (in connect.c) that should _not_ go to production. > > You added the support for proxy for FTPS, which I ended up forgotting. > Well done! > > Tell me if you still see something broken. > > Regards, > - AJ > > On Fri, 2015-09-11 at 10:54 +0200, Tim Ruehsen wrote: > > Hi Ander, > > > > two things that I found. > > > > 1. [PATCH 0002] Some FTPS pieces seem to be missing. > > I went through the code by searching for SCHEME_FTP and "ftp" and added > > FTPS stuff where it was missing. I did not think throughly about what I > > did - so please just don't apply those changes blindly. > > > > With those changes, Wget tried to work recursively but hangs on the first > > PASSIVE data transfer. > > > > 2. [PATCH 0003 ]'using_data_security' in getftp() is a local variable, > > reset for each file, and only set if (prot != PROT_CLEAR). I turned the > > logic and voila, recursion works. Again, think if this change might break > > something else that I didn't test. > > > > Regards, Tim
