Looks good, go ahead ! Tim
On Thursday 03 December 2015 18:55:27 Darshit Shah wrote: > Now that --without-ssl works again, I thought it'd be a good time to finish > Travis too. > > Attached is an updated patch. Along with my other pending patch for fixing > the test suite, this works perfectly and all tests currently pass. > > As mentioned earlier, multicolumn character languages still have a bug. I > will debug that as soon as I get some time. Till then, the test suite works > only on the C locale. > > I'd like to push this as soon as possible. > > On 11/18, Tim Rühsen wrote: > >Hi Darshit, > > > >great work ! > > > >The Travis yml file is much cleaner than the ones that I use :-) > > > >There is a small type: 'suppresion' should be 'suppression' (in the > >valgrind suppression files). > > > >Regards, Tim > > > >On Wednesday 18 November 2015 00:17:41 Darshit Shah wrote: > >> It's been a while since I shared these patches. The fixes to make > >> distcheck > >> went in before the last release, however, we still don't have Travis > >> integration. The API Tim linked to is valid only for private builds which > >> is a paid feature of Travis. > >> > >> Since the Turkish tests were failing due to a bad translation, I've > >> currently removed it from the list of languages. Once we have the > >> translation fixed, we can add the Turkish language back into the tests. > >> I'd > >> like to have that language in because of the specific corner case > >> provided > >> in its character set. > >> > >> Apart from that, I randomly picked and added Japanese against a language > >> to > >> test against. This was chosen because it has multi-byte and multi-column > >> characters and I want to ensure that the progress bar works perfectly for > >> these. Turns out in one particular case it doesn't. Which is why the > >> current Travis setup fails too. Hence, I removed the language for now so > >> that we have a working Travis setup. However, that was a valid bug and we > >> need to look into fixing it. > >> > >> Currently, the only build that fails is one with --without-ssl. While I > >> understand that this is a ridiculous idea in this day, but we provide a > >> configure option to build without SSL and should support it. I've left it > >> there since it's a more major issue we need to look into before the next > >> minor release. > >> > >> Email notifications from Travis are not currently working. I will discuss > >> this on IRC with them tomorrow to see how we can fix this. > >> > >> I've attached the new patch for Travis integration and will push it if no > >> one complains. > >> > >> Eventually, I'd like to extend this travis file to cover OSX builds too. > >> But currently, the OSX environment seems to have some problems with > >> Python that requires some manual work. Hence, I've not included the OSX > >> as a target OS for testing in this patch. > >> > >> On 10/11, Tim Rühsen wrote: > >> >Am Sonntag, 11. Oktober 2015, 12:32:14 schrieb Darshit Shah: > >> >> However, I did come across a small problem. Travis currently accepts > >> >> open source build requests from GitHub only. So I don't think we can > >> >> use it from Savannah. Would it be a problem if we pushed the > >> >> .travis.yml to master and allow the builds to be fired from one of our > >> >> GitHub clones? > >> > > >> >Hi Darshit, > >> > > >> >IMO there is no problem. > >> > > >> >If there is no possibility to trigger a build from Savannah, we have to > >> >use > >> >Github. Or we have to trigger it manually... > >> > > >> >That is something that other people already asked for: > >> >http://kamranicus.com/blog/2015/03/29/triggering-a-travis-build-programm > >> >ati > >> >cally/ > >> > > >> >Maybe you could give this a try (maybe using wget instead of curl ?). > >> >http://docs.travis-ci.com/user/triggering-builds/ > >> > > >> >Regards, Tim
