On 10 February 2016 at 22:41, Kushagra Singh <[email protected]> wrote: > I figured out the mistake, I guess. The cookie was getting expired and > wasn't getting saved to the file. I added --keep-session-cookies to > WGET_OPTIONS, now I can see the cookies being saved in the file. > > In the test, I am removing the first 4 lines of the cookie file (which WGET > generates) and then saving it again. Since no cookie should exist (in this > case), I am comparing it to an empty file using the ExpectedFiles hook. > > Without the patch (0003), the test shouldn't pass, as the secure cookie is > set. Although there is an error raised "Error: Contents of mycookies.wget do > not match." in the test log, the test suit doesn't fail explicitly. Is this > supposed to happen?
No. This is a bug, if the posthook fails, the test must fail explicitly. Need to look into this. > > After applying the patch (0003), the error is no longer raised in the log. > > Patches and test log are attached. > > Thank you, > Kushagra > -- Thanking You, Darshit Shah
