On Sunday 10 April 2016 12:40:01 Giuseppe Scrivano wrote: > Hi Tim, > > Tim Rühsen <[email protected]> writes: > > Am Samstag, 9. April 2016, 10:46:23 schrieb Giuseppe Scrivano: > >> Hi Tim, > >> > >> Tim Ruehsen <[email protected]> writes: > >> > @@ -27,7 +28,7 @@ class BaseTest: > >> > Define the class-wide variables (or attributes). > >> > Attributes should not be defined outside __init__. > >> > """ > >> > > >> > - self.name = name > >> > + self.name = os.path.basename(os.path.realpath(sys.argv[0])) > >> > > >> > # if pre_hook == None, then {} (an empty dict object) is > >> > passed > >> > to > >> > # self.pre_configs > >> > self.pre_configs = pre_hook or {} > >> > >> shouldn't we remove name from __init__? > > > > That is what I meant with > > "This is patch 0002-... just as suggestion, to complete it > > we have to remove all occurrences of TEST_NAME from the python tests." > > > > I didn't want to waste my time and change code at 30+ places before I know > > that such a change is welcome. > > sure. Sorry I jumped immediately to the patches :) I think it is a > good change.
:-) I made 0002 complete and pushed all three patches. This should unlock Travis' patch set, I'm going to test these now without TEST_NAME. Tim
