Thanks for looking more closely than I did, Ander ! On Friday, July 22, 2016 2:22:51 PM CEST Ander Juaristi wrote: > Hi Sean, > > Great patch! > > But I just had some unimportant comments about coding style ;D > > remove the braces, and indent the if body by two spaces > > we use spaces before the parentheses: > fileno (fp) and strlen (value)
The patch has already been pushed, but feel free to make a follow-up patch with these things corrected. > > + /* FreeBSD's extattr_set_fd returns the length of the extended > > attribute. */ + retval = (retval < 0)? retval : 0; > > and before the '?' I did that before pushing. Tim
signature.asc
Description: This is a digitally signed message part.
