Re: [Bug-wget] buildbot failure in OpenCSW Buildbot on wget-solaris10-i386

[Matthew White]

On Thu, 04 Aug 2016 12:17:36 +0200
build...@opencsw.org wrote:

> The Buildbot has detected a new failure on builder wget-solaris10-i386 while 
> building wget.
> Full details are available at:
>  
> https://buildfarm.opencsw.org/buildbot/builders/wget-solaris10-i386/builds/162
> 
> Buildbot URL: https://buildfarm.opencsw.org/buildbot/
> 
> Buildslave for this Build: unstable10x
> 
> Build Reason: scheduler
> Build Source Stamp: [branch master] 943a6d585ff4a0afd974ab2e4838c9d2a63cf21a
> Blamelist: Matthew White <mehw.is...@inventati.org>
> 
> BUILD FAILED: failed shell_2 shell_3
> 
> sincerely,
>  -The Buildbot
> 
> 
> 
> 

Sorry,

I read the log, the problem seems to be non-ASCII characters.

The fix is attached to this message.

Let me know!

-- 
Matthew White <mehw.is...@inventati.org>

>From f3235ffc9448da72e27cf0e6acd370d08b2393f9 Mon Sep 17 00:00:00 2001
From: Matthew White <mehw.is...@inventati.org>
Date: Thu, 4 Aug 2016 12:59:52 +0200
Subject: [PATCH 2/2] Bugfix: Use quote() to quote strings

* src/metalink.c (badhash_suffix): Use quote() to quote strings

Fixes:
* Builder wget-solaris10-i386 Build #162
* Builder wget-solaris10-sparc Build #167
---
 src/metalink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/metalink.c b/src/metalink.c
index 2e296f9..147ab94 100644
--- a/src/metalink.c
+++ b/src/metalink.c
@@ -567,7 +567,7 @@ badhash_suffix (char *name)
   bhash = concat_strings (name, ".badhash", (char *)0);
   uname = unique_name (bhash, false);
 
-  logprintf (LOG_VERBOSE, _("Renaming ‘%s’ to ‘%s’.\n"), name, uname);
+  logprintf (LOG_VERBOSE, _("Renaming %s to %s.\n"), quote (name), quote (uname));
 
   if (link (name, uname))
     logprintf (LOG_NOTQUIET, "link: %s\n", strerror (errno));
-- 
2.7.3

pgpY8gtqfZHku.pgp
Description: PGP signature