Re: [Bug-wget] [PATCH 09/25] Enforce Metalink file name verification, strip directory if necessary

[Tim Ruehsen]

On Saturday, September 10, 2016 12:49:50 PM CEST Matthew White wrote:

> +int metalink_check_safe_path(const char *path);

One space before (, please ;-)

> +  char *basename = name;
> +
> +  while ((name = strstr (basename, "/")))
> +    basename = name + 1;

Could you use strrchr() ? something like

char *basename = strrchr (name, '/');

if (basename)
  basename += 1;
else
  basename = name;

Regards, Tim

signature.asc
Description: This is a digitally signed message part.