Hi. I would like to get feedback on a subtle change of behavior in wget between version 1.14 and the current upstream version, which has been pointed out by our distribution users.
Before change [1], wget didn't produce any output related to loading CA certificates when --no-verbose option has been used. When --no-verbose option is used, only error messages and basic information should get printed. Information about loading CRL or CA certificate is probably not a basic information. Any error when loading the CRL or CA certificate will be still printed with --no-verbose. Some users rely on wget not printing such information and they consider it a regression. Reported as https://bugzilla.redhat.com/show_bug.cgi?id=1807267 I'm attaching a patch which makes wget to print the message about loading CRL or CA certificate file only in verbose mode (the default). [1] http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e4a8fe84e2b813b65d91aec29298eecabe4850a5 Regards, Tomas -- Tomas Hozza Manager, Software Engineering - EMEA ENG Core Services PGP: 1D9F3C2D UTC+1 (CET) Red Hat Inc. http://cz.redhat.com
>From 76ff257f3a0555867543d11c57414c6bc64e7307 Mon Sep 17 00:00:00 2001 From: Tomas Hozza <[email protected]> Date: Tue, 24 Mar 2020 13:18:40 +0100 Subject: [PATCH] Don't print message about loading crl or ca-cert files with --no-verbose * src/gnutls.c (ssl_init): Use LOG_VERBOSE verbosity for informative message related to loading CRL or CA certificate file. Before change [1], wget didn't produce any output related to loading CA certificates when --no-verbose option has been used. When --no-verbose option is used, only error messages and basic information should get printed. Information about loading CRL or CA certificate is probably not a basic information. Any error when loading the CRL or CA certificate will be still printed with --no-verbose. Some users rely on wget not printing such information and they consider it a regression. Reported as https://bugzilla.redhat.com/show_bug.cgi?id=1807267 [1] http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e4a8fe84e2b813b65d91aec29298eecabe4850a5 Signed-off-by: Tomas Hozza <[email protected]> --- src/gnutls.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gnutls.c b/src/gnutls.c index e95ecea0..7ab1f088 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -172,7 +172,7 @@ ssl_init (void) else { ncerts += rc; - logprintf (LOG_NOTQUIET, _ ("Loaded CA certificate '%s'\n"), opt.ca_cert); + logprintf (LOG_VERBOSE, _ ("Loaded CA certificate '%s'\n"), opt.ca_cert); } } @@ -186,7 +186,7 @@ ssl_init (void) return false; } - logprintf (LOG_NOTQUIET, _ ("Loaded CRL file '%s'\n"), opt.crl_file); + logprintf (LOG_VERBOSE, _ ("Loaded CRL file '%s'\n"), opt.crl_file); } DEBUGP (("Certificates loaded: %d\n", ncerts)); -- 2.21.1
