Issue #2990 has been updated by dillon. Status changed from New to Closed
fix committed to master ---------------------------------------- Bug #2990: sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition http://bugs.dragonflybsd.org/issues/2990#change-13097 * Author: dcb * Status: Closed * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- dragonfly/sys/boot/efi/boot1/boot1.c:652]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses. Source code is if ((status = bs->AllocatePool(EfiLoaderData, hsize, (void **)&handles) != EFI_SUCCESS)) { Maybe better code if ((status = bs->AllocatePool(EfiLoaderData, hsize, (void **)&handles)) != EFI_SUCCESS) { -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account