Issue #3011 has been updated by swildner. Status changed from New to In Progress
Yes, it could be a typo, and MACFG_25 is intended, it could as well be a sloppy intentional last minute "fix" and the intention is to exclude MACFG_25 from the if(). My bet is typo, though. I mailed Realtek about it. Let's see if they get back to me. ---------------------------------------- Bug #3011: dragonfly/sys/dev/netif/re/re.c: suspicious code ? http://bugs.dragonflybsd.org/issues/3011#change-13191 * Author: dcb * Status: In Progress * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- dragonfly/sys/dev/netif/re/re.c:6567] -> [dragonfly/sys/dev/netif/re/re.c:6567]: (style) Same expression on both sides of '||'. [dragonfly/sys/dev/netif/re/re.c:21948] -> [dragonfly/sys/dev/netif/re/re.c:21948]: (style) Same expression on both sides of '||'. [dragonfly/sys/dev/netif/re/re.c:21949] -> [dragonfly/sys/dev/netif/re/re.c:21949]: (style) Same expression on both sides of '||'. [dragonfly/sys/dev/netif/re/re.c:22044] -> [dragonfly/sys/dev/netif/re/re.c:22044]: (style) Same expression on both sides of '||'. [dragonfly/sys/dev/netif/re/re.c:22104] -> [dragonfly/sys/dev/netif/re/re.c:22104]: (style) Same expression on both sides of '||'. Taking the first one as an example: if ((sc->re_type == MACFG_24) || (sc->re_type == MACFG_24) || (sc->re_type == MACFG_26)) MACFG_25 exists. Possible cut'n'paste error ? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
