Issue #3102 has been updated by swildner. Status changed from New to Closed
I've pushed a fix. It was fixed in Linux too (3a61b527b4e1f285d21b6e9e623dc45cf8bb391f). Thanks. ---------------------------------------- Bug #3102: sys/dev/drm/radeon/radeon_uvd.c:897: possible cut'n'paste issue ? http://bugs.dragonflybsd.org/issues/3102#change-13443 * Author: dcb * Status: Closed * Priority: Normal * Assignee: * Category: Kernel * Target version: ---------------------------------------- dragonfly/sys/dev/drm/radeon/radeon_uvd.c:897] -> [dragonfly/sys/dev/drm/radeon/radeon_uvd.c:903]: (warning) Identical condition 'vclk_div>pd_max', second condition is always false Source code is if (vclk_div > pd_max) break; /* vco is too big, it has to stop */ /* calc dclk divider with current vco freq */ dclk_div = radeon_uvd_calc_upll_post_div(vco_freq, dclk, pd_min, pd_even); if (vclk_div > pd_max) break; /* vco is too big, it has to stop */ Maybe the 2nd if would be better if it sanity checked dclk_div, like if (dclk_div > pd_max) break; /* vco is too big, it has to stop */ -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
