DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19165>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19165 improperly initialized variable Summary: improperly initialized variable Product: Apache httpd-1.3 Version: HEAD Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: mod_proxy AssignedTo: [email protected] ReportedBy: [EMAIL PROTECTED] >From ap_proxy_http_handler() in proxy_http.c, in the following code fragment (whether or not SINIX_D_RESOLVER_BUG is defined), variable i will never be properly initialized if the loops are never entered. #ifdef SINIX_D_RESOLVER_BUG { struct in_addr *ip_addr = (struct in_addr *)*server_hp.h_addr_list; for (; ip_addr->s_addr != 0; ++ip_addr) { memcpy(&server.sin_addr, ip_addr, sizeof(struct in_addr)); i = ap_proxy_doconnect(sock, &server, r); if (i == 0) break; } } #else j = 0; while (server_hp.h_addr_list[j] != NULL) { memcpy(&server.sin_addr, server_hp.h_addr_list[j], sizeof(struct in_addr)); i = ap_proxy_doconnect(sock, &server, r); if (i == 0) break; j++; } #endif if (i == -1) { if (proxyhost != NULL) return DECLINED; /* try again another way */ else return ap_proxyerror(r, HTTP_BAD_GATEWAY, ap_pstrcat(r->pool, "Could not connect to remote machine: ", strerror(errno), NULL)); } Here is a suggested patch: RCS file: /home/cvspublic/apache-1.3/src/modules/proxy/proxy_http.c,v retrieving revision 1.103 diff -c -r1.103 proxy_http.c *** proxy_http.c 3 Feb 2003 17:13:26 -0000 1.103 --- proxy_http.c 18 Apr 2003 22:28:47 -0000 *************** *** 259,264 **** --- 259,265 ---- } #endif + i = -1; #ifdef SINIX_D_RESOLVER_BUG { struct in_addr *ip_addr = (struct in_addr *)*server_hp.h_addr_list; --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
