DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35250>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35250 Summary: add logging to mod_proxy_connect on failed connect Product: Apache httpd-2.0 Version: 2.0-HEAD Platform: All OS/Version: All Status: NEW Keywords: PatchAvailable Severity: enhancement Priority: P5 Component: mod_proxy AssignedTo: [email protected] ReportedBy: [EMAIL PROTECTED] Adding logging when ap_proxy_connect_handler fails to connect (two XXX's and two extra ones) Index: modules/proxy/proxy_connect.c =================================================================== --- modules/proxy/proxy_connect.c (revision 185054) +++ modules/proxy/proxy_connect.c (working copy) @@ -154,12 +154,12 @@ case APR_URI_SNEWS_DEFAULT_PORT: break; default: - /* XXX can we call ap_proxyerror() here to get a nice log message? */ - return HTTP_FORBIDDEN; + return ap_proxyerror(r, HTTP_FORBIDDEN, + "Connect to remote machine blocked"); } } else if(!allowed_port(conf, uri.port)) { - /* XXX can we call ap_proxyerror() here to get a nice log message? */ - return HTTP_FORBIDDEN; + return ap_proxyerror(r, HTTP_FORBIDDEN, + "Connect to remote machine blocked"); } /* @@ -194,10 +194,12 @@ /* handle a permanent error from the above loop */ if (failed) { if (proxyname) { - return DECLINED; + return ap_proxyerror(r, DECLINED, + "Connect to remote machine declined"); } else { - return HTTP_BAD_GATEWAY; + return ap_proxyerror(r, HTTP_BAD_GATEWAY, + "Connect to remote machine failed - HTTP_BAD_GATEWAY"); } } -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
