DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39380>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39380





------- Additional Comments From [EMAIL PROTECTED]  2006-10-08 10:37 -------
Created an attachment (id=18979)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=18979&action=view)
Fixups for the load/store-patch.

I discovered a few misses, mostly not NULL:ing fd pointers when closing
them, missing close/flush, and some unneccessary code duplication instead of
calling the right helper in replace_brigade_with_cache().

The misses are in the load/store-patch, so I would recommend applying this
before reviewing the results even though it's generated from a file with the
read-while-caching patch applied.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to