DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=41143>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=41143 ------- Additional Comments From [EMAIL PROTECTED] 2007-06-28 16:18 ------- (In reply to comment #6) > (In reply to comment #5) > > > But ap_get_brigade(AP_MODE_GETLINE) returns 8192 bytes at max and it is not > guaranteed that this data contains a LF. No! ap_get_brigade(AP_MODE_GETLINE) may return much more than 8192 bytes. Suppose a brigade has two buckets of APR_BUCKET_BUFF_SIZE (8000) bytes each and the line break is on the second bucket, at position 4000. In this case, apr_brigade_split_line() will read the first bucket, and will proceed to read the next one since it's size is not >= HUGE_STRING_LEN. It will find a LF on the second one and return a brigade of 12000 bytes. > I agree that current code does it wrong, but I fear that there are other cases > where your patch will do it wrong. Would you care to elaborate? Also, i'm not sure too if it's the best fix, but it can't get any worse (famous last words). -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
