https://issues.apache.org/bugzilla/show_bug.cgi?id=38642





--- Comment #25 from Aleksander Budzynowski <[email protected]>  2008-12-19 
20:46:28 PST ---
> Ultimately I'm just more comfortable A) not regressing anyone with a legacy
> ruleset lurking out in htaccess and B) making the choice explicit in the rule
> after consulting the doc.

I can see where you're coming from, but in my opinion, placing extra burden on
users for backwards-compatibility reasons should be avoided as much as
possible.

I've had an idea: rather than using r->path_info, we add a path_info member to
rewrite_ctx, and refer to that within mod_rewrite. It would be initialised to
r->path_info, but could be set to NULL when a substitution is made. This way
the request's PATH_INFO information is not actually modified by mod_rewrite.

Any comments?


Earlier I said
> The flag is stored in r->notes - I can't see where better to put it. It can't
> go in the ctx struct because the scope of that struct is a single rewrite 
> list.

I no longer think this is true. r->path_info is regenerated at the end of a
rewrite list (providing at least one rule matched) so we can start afresh for
each rewrite list.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to