https://issues.apache.org/bugzilla/show_bug.cgi?id=47753
Summary: output and error channels not explicitly passed for
ap_os_create_privileged_process()
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: normal
Priority: P2
Component: All
AssignedTo: [email protected]
ReportedBy: [email protected]
--- Comment #0 from Boya Sun <[email protected]> 2009-08-27 12:32:14 PDT ---
It seems that in modules\generators\mod_cgi.c, function run_cgi_child(),
"apr_procattr_child_err_set()" and "apr_procattr_child_out_set()" are missing
to explicitly pass output and error channels before
"ap_os_create_privileged_process()".
This potential bug is similar to revision 602467. The log of this revision is
as follows:
" * core log.c: Work around possible solutions rejected by apr for the old
implementation of apr_proc_create(), and explicitly pass the output and error
channels to all log processes created. This goes all the way back to piped logs
failing to run on win32. Not in or needed at trunk/, as apr 1.3.0 has the
proper fix."
It seems that the above log also holds for "ap_os_create_privileged_process()".
An evidence is the following code in revision 806782 of branch 2.2.x where the
two apr_procattr_child_*_set functions *ARE* called before the function:
*************************************************************
File: modules\generators\mod_cgid.c
Function: cgid_server
758 ((rc = apr_procattr_child_err_set(procattr,
r->server->error_log, NULL)) != APR_SUCCESS) ||
...
760 ((rc = apr_procattr_child_out_set(procattr, inout, NULL)) !=
APR_SUCCESS) ||
...
790 rc = ap_os_create_privileged_process(r, procnew, argv0,
argv,
*************************************************************
The patch I attached is not a bug-fix, but some comments indicating where the
two missing functions should be added to better illustrate my point.
Any comment is greatly appreciated.
Boya
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
