https://issues.apache.org/bugzilla/show_bug.cgi?id=47812
Summary: error_log hook often does not have access to the
request_rec
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Core
AssignedTo: [email protected]
ReportedBy: [email protected]
--- Comment #0 from Philip Pickett <[email protected]> 2009-09-09
14:43:33 PDT ---
There are places in the code that don't have access to a request_rec, however
there seem to be a lot of places where developers go out of their way to _not_
pass a request_rec to ap_log_rerror but instead use ap_log_error (according to
a very quick grep of the source code), there are >250 counts of things like
this happening:
from mod_proxy_util.c, line 2102:
-----------------------------------------
ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, r->server,
"proxy: connecting %s to %s:%d", *url, uri->hostname,
uri->port);
-----------------------------------------
... where a server is passed to ap_log_error() *from a valid request_rec* for
no apparent reason. It seems to me the vast majority of error log messages that
would be useful to be able to tally with the source request come from
ap_log_error calls like this.
According to the documentation for ap_log_error() in http_log.h:
"If a request_rec is available, use that with ap_log_rerror() in preference to
calling this function. Otherwise, if a conn_rec is available, use that with
ap_log_cerror() in preference to calling this function"
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
