https://issues.apache.org/bugzilla/show_bug.cgi?id=47935
--- Comment #7 from Stefan Nowak <[email protected]> 2009-10-02 10:10:17 PDT --- (In reply to comment #6) > Agree with Dan - hence my "poor example" comment: even just replacing "except > in" with "unless" would be an improvement, but that still leaves issues like > testing for "word"s when in fact it tests strings. Better to drop it, except > that loses an example that could, despite all the faults, be helpful to users. Suggestion 1: Replace "except" with "unless" as Nick Kew and André Malo suggest. Small change, but already improves the semantic understanding quite well! Suggestion 2: The current text, which describes the intended purpose by using a confusing negotiation ("except ... contain" although the code says "does not contain"). Better use a simple wording, which reflects what you see in the code: For example, to deny requests whose query string contains the word "hack" and whose cookie does not contain the word "go", you could use: [...] > Let's not forget we can improve it for 2.3 and up, where this kind of ugly > mod_rewrite hackery is obsoleted: > <If ("%{QUERY_STRING} = /hack/) && !(%{HTTP_COOKIE} = /go/)"> > Deny from All > </If> Nice to see, that 2.3 grants more complex logic expressions! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
