https://issues.apache.org/bugzilla/show_bug.cgi?id=50481
--- Comment #10 from Joe Orton <[email protected]> 2011-04-07 08:17:08 EDT --- For reference, the change committed to 2.2.x was r1069427 You pose good questions! This code is particularly arcane. We had some list discussion of this: http://www.mail-archive.com/[email protected]/msg49951.html (In reply to comment #8) > Questions/comments on the patch: > > * what would be returned at end of stream without CR/LF? I suspect the code > would just not return the last bit of data... I believe it would fail with APR_EOF; not particularly sure though. > * what are the semantics of MODE_GET_LINE? Is it OK to return an error and > data? Per list discussion... it's not really clear. > * char_buffer_write doesn't append. If the function gets EAGAIN twice in a > row, it will clobber the first bit of data. In the case where ssl_io_input_read() is called with a non-empty cbuf, that function will copy the cbuf contents into the passed-in 'buf' buffer; so it gets copied out then the cbuf pointers are reset. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
