https://issues.apache.org/bugzilla/show_bug.cgi?id=51699
Bug #: 51699
Summary: Code clean up (use apr_pstrcat where appropriate)
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: PC
OS/Version: Windows 2000
Status: NEW
Severity: enhancement
Priority: P2
Component: All
AssignedTo: [email protected]
ReportedBy: [email protected]
Classification: Unclassified
Created attachment 27418
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27418
Proposed patch
Hi,
I've spotted two places where we could use 'apr_pstrcat' instead of the hand
coded equivalent sequence.
IMO, this improve a lot readability of the code.
However, the proposed patch is a little slower than the original code because
we need to compute twice the length of the string (once in apr_pstrcat and one
with a strlen I have to add)
So, if you think that there is no need to apply this patch, just close the
report.
As i'm still enable to compule httpd on my machine, the patch is untested and
provided as-is.
Best regards,
Christophe JAILLET
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
