https://issues.apache.org/bugzilla/show_bug.cgi?id=54000
Priority: P2
Bug ID: 54000
Assignee: [email protected]
Summary: Typo in procmgr_send_spawn_cmd() resulting in longer
wrapper startup (SVN rev. 1397462)
Severity: normal
Classification: Unclassified
OS: Linux
Reporter: [email protected]
Hardware: PC
Status: NEW
Version: 2.4.3
Component: mod_fcgid
Product: Apache httpd-2
Created attachment 29469
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29469&action=edit
Fix typo in fcgid_pm_unix.c:489 (nbytes => notifybyte)
mod_fcgid version: SVN rev. 1397462
There is a minor typo in fcgid_pm_unix.c:489:
/* Wait the finish notify while send the request successfully */
nbytes = sizeof(notifybyte);
if ((rv =
apr_file_read(g_ap_read_pipe, ¬ifybyte,
&nbytes)) != APR_SUCCESS) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, rv, r,
"mod_fcgid: can't get notify from process manager");
result = rv;
====> } else if( nbytes!=PROCMGR_PROC_CREATED )
result = APR_CHILD_NOTDONE;
There should be notifybyte instead of nbytes. In most (all?) cases sizeof(char)
is 1 and PROCMGR_PROC_CREATED is defined as 0 so comparison nbytes !=
PROCMGR_PROC_CREATED always fails. As a result condition in fcgid_bridge.c:450
always fails and 1 second apr_sleep() is always applied before spawning
wrapper.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
