https://issues.apache.org/bugzilla/show_bug.cgi?id=55304
Bug ID: 55304
Summary: [PATCH] mod_dav should not validate parent when
handling COPY
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: Mac OS X 10.4
Status: NEW
Severity: normal
Priority: P2
Component: mod_dav
Assignee: [email protected]
Reporter: [email protected]
Created attachment 30623
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30623&action=edit
Only validate the parent in the case of MOVE and not COPY.
The fix that was applied for PR54610 changed mod_dav to run the
dav_validate_request() function on COPY requests as well as MOVE requests.
This was done by effectively just removing the if block around the existing
MOVE case.
The URI of the COPY and MOVE requests is the source of the node to be copied or
moved. So DAV_VALIDATE_PARENT ends up asking the DAV provider module for the
parent resource. As the comment above this call mentions this makes sense for
a MOVE since the parent of the node being moved is modified by the move.
However, in the case of a COPY it is not.
If the source happens to be the root of the DAV repository, then there will be
no parent to provide. This isn't a problem for MOVE because there's no logical
way to handle moving the root, however a COPY of the root is allowed. A
properly implemented DAV provider will return NULL for the parent resource and
as a result the COPY from the root will fail incorrectly.
This issue causes the Subversion test suite to fail prior to Subversion 1.7.11
and 1.8.1 when we put a fix in for a bug in our code get_parent_resource() code
that was asserting when run against the root. We still have another bug where
for some resources we are not returning NULL like we should be (as mentioned
above) when asked for the parent of the root. Without this issue being fixed
we can't fix our bug.
So an easy way to reproduce this issue would be simply to run the SVN test
suite with a checkout from the Subversion repo before r1503528 (when the issue
was fixed on trunk). You'll see authz_tests.py 17 fail and some tests later
on.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
