https://issues.apache.org/bugzilla/show_bug.cgi?id=55669

--- Comment #8 from Yann Ylavic <[email protected]> ---
Created attachment 31473
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31473&action=edit
Don't add Expires header on errors (really)

(In reply to Edward Lu from comment #7)
> It looks like this is happening only when something external to Apache is
> returning an error code. This code, inside expires_insert_filter(), isn't
> getting run:
> 
>     /* Don't add Expires headers to errors */
>     if (ap_is_HTTP_ERROR(r->status)) {
>         return;
>     }
> 

The insert_filter hook is run at the begining of ap_invoke_handler(), before
any error is set (either by the httpd or the backend).

This code makes no sense here, I think it should be moved to the output filter
itself, like in the attached patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to