https://issues.apache.org/bugzilla/show_bug.cgi?id=56480
Ben Reser <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31602|0 |1 is obsolete| | --- Comment #2 from Ben Reser <[email protected]> --- Created attachment 31705 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31705&action=edit potential patch version 4 Improved patch that fixes something I found in the process of writing a test suite for mod_dav_fs to validate the previous fix. [[[ Fix PR 56480: PROPFIND walker doesn't encode hrefs properly Reverts r1529559 partially (specifically the dav_xml_escape_uri) bit. Reverts r1531505 entirely. * modules/dav/main/mod_dav.c (dav_xml_escape_uri): Revert the piece of r1529559 that removes the URI escaping from this function. * modules/dav/main/props.c (dav_do_prop_subreq): Escape the URI before doing a sub request with it. This resolves some properties like getcontenttype from failing to be returned for files that contain characters that require encoding in their path. * modules/dav/main/mod_dav.h (dav_resource): Note the inconsistency in the documentation. * modules/dav/fs/repos.c (dav_fs_get_resource): Don't use the unparsed_uri to set the uri field of the resource. This is the correct fix for the double encoding in mod_dav_fs that led to the dav_xml_escape_uri() change and r1531505. (dav_fs_walker, dav_fs_append_uri): Revert r1531505 changes. ]]] -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
