https://issues.apache.org/bugzilla/show_bug.cgi?id=57085
--- Comment #5 from Guillermo Grandes <[email protected]> --- (In reply to ywu from comment #2) > I have implemented a similar module under testing for appache 2.4, following > ngix's patch. I am curious why your code didn't put source ip from proxy > protocol line into c->client_ip and c->client_addr (your code use c->notes > to store client_ip)? You threw away destination_ip from protocol line now. > Do you have plan to use it, which my current effort to integrate it with > apache mod_proxy? Yes, I dont touch c->client_ip in 2.4 module, I use r->useragent_ip (that is not available in connection_filter, until post_read) because... I read the change in API (http://httpd.apache.org/docs/2.4/developer/new_api_2_4.html), that say (about c->remote_ip): >> 1) When you require the IP address of the user agent, which might be >> connected directly to the server, or might optionally be separated from the >> server by a transparent load balancer or proxy, use >> request_rec->useragent_ip and request_rec->useragent_addr. >> 2) When you require the IP address of the client that is connected directly >> to the server, which might be the useragent or might be the load balancer or >> proxy itself, use conn_rec->client_ip and conn_rec->client_addr. This seems that usage of c->client_ip is not the good way for PROXY protocol. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
