https://bz.apache.org/bugzilla/show_bug.cgi?id=57742
Edward Lu <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32604|0 |1 is obsolete| | --- Comment #5 from Edward Lu <[email protected]> --- Created attachment 32627 --> https://bz.apache.org/bugzilla/attachment.cgi?id=32627&action=edit Enable reliable piped logging for error logs Here's a patch that enables reliable piped logging on both the main and virtualhost error logs. It seems to work fine on some simple tests. The patch is a little more complicated than anticipated; it wasn't enough to simply attach the maintenance function to the main error logging program. Here's a description of the problem I was running into, for any reviewers: for the main error log, we close the fd originally intended to be used as the writing end of the pipe to rotatelogs, and use stderr instead. However, when rotatelogs goes down, we try to re-use the original fd as the descriptor for the pipe to the new rotatelogs process, which fails since the descriptor's been closed. I got around this by stashing away the stderr descriptor instead of the original fd, and then making sure that it doesn't get cleaned up. I also introduced an ap_open_piped_log_helper() function to pass dummy_stderr down, so we can still avoid the problem described in PR40651. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
