https://bz.apache.org/bugzilla/show_bug.cgi?id=59829

Yordan Gigov <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34711|0                           |1
        is obsolete|                            |

--- Comment #19 from Yordan Gigov <[email protected]> ---
Created attachment 34741
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34741&action=edit
Fix data loss when using mod_rewrite

Fixing patch fixes merge conflicts introduced in the following commit
---
commit b960c87946085b8335da3e8b9b8749e3562f87cd
Author: Daniel Ruggeri <[email protected]>
Date:   Sat Feb 4 20:14:18 2017 +0000

    Change tactic for PROXY processing in Optional case

    git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1781701
13f79535-47bb-0310-9956-ffa450edef68
---

In addition it attempts to detect when the proxy server is reached via it's
remote port (set by SecureIndicatorSSLPort or default to 443) when using
ProxyProtocol.

It also addresses an issue where using mod_rewrite to internally rewrite the
request. The HTTPS environment variable had been renamed from 'HTTPS' to
'REDIRECT_HTTPS' in the `internal_internal_redirect` function.

Personally I don't see why it needs to be that way, instead of just copying the
table. It just forces mod_ssl (and now this mod) to use an extra hook for no
good reason. The code that does it has been in there since 2000.

Note: this still does not touch on mod_rewrite's problem of relying entirely on
mod_ssl being loaded to check the `HTTPS` condition.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to