https://bz.apache.org/bugzilla/show_bug.cgi?id=57525

--- Comment #9 from Jose Kahan <j...@w3.org> ---
(In reply to Yann Ylavic from comment #7)
> Created attachment 35472 [details]
> Revert pre_config hook and fix lazy initialization
> 
> Thanks José for the analysis, the pre_config hook indeed kills further use
> of macros (.htaccess), and lazy initialization must not use the temporary
> pool too.
> 
> Does this patch work for you?

Hello Yann,

Thank you. The patch works as expected in my installation. Our testsuite didn't
find any issue with it. I like the elegant ap in-built functions way you did
it, without having to define a new function.

One question. Would doing the following ap_assert be overkill in the lazy
initialization?

else {
 ap_assert(ap_macros != NULL)
 pool = apr_hash_pool_get(ap_macros);
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org
For additional commands, e-mail: bugs-h...@httpd.apache.org

Reply via email to