https://bz.apache.org/bugzilla/show_bug.cgi?id=61616
--- Comment #58 from Mohamed El Housseine <elh.moha...@gmail.com> --- Hi Yann, thank you for your feedback! > It also keeps the ap_proxy_transfer_between_connections() logic in one > place, to avoid duplicating code (and error handling, which seems to be > missing in attachment 35776 [details]). The error handling is not missing, I analyzed all possible returns of ap_proxy_transfer_between_connections, it can return: APR_SUCCESS APR_STATUS_IS_INCOMPLETE APR_STATUS_IS_EOF ERROR In its second call (for handling remaining data in input filters) it can return: APR_SUCCESS APR_STATUS_IS_INCOMPLETE ERROR APR_STATUS_IS_EOF can't be returned, because we are handling remaining (existing) data. Also if the second call returns something different than APR_SUCCESS or APR_STATUS_IS_INCOMPLETE it must be handled as error. For ensuring this, extending the if-condition for handling data_in_output_filters with "&& !APR_STATUS_IS_EAGAIN(rv)" must be enought. maybe I missed another case? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscr...@httpd.apache.org For additional commands, e-mail: bugs-h...@httpd.apache.org
