https://bz.apache.org/bugzilla/show_bug.cgi?id=62823
--- Comment #3 from Arnaud Grandville <[email protected]> --- (In reply to Ruediger Pluem from comment #1) > (In reply to Arnaud Grandville from comment #0) > > I'm writing a module to translate http rest/json calls to pkcs11 protocol. > > I found a curious behavior, if the client gives up his request, whereas I > > use the %X flag is specified in my logFormat, the access log didn't report > > the request as cancelled with a "X". > > > > My module ends with several calls to ap_rwrite and return OK. > > But in server\core_filters.c when the brigade send fails the brigade is > > cleaned and request is logged before aborded status was updated > > > > ... > > rv = send_brigade_blocking(net->client_socket, bb, > > &(ctx->bytes_written), c); > > if (rv != APR_SUCCESS) { > > /* The client has aborted the connection */ > > ap_log_cerror(APLOG_MARK, APLOG_TRACE1, rv, c, > > "core_output_filter: writing data to the > > network"); > > apr_brigade_cleanup(bb); > > c->aborted = 1; > > return rv; > > } > > ... > > > > would it not be necessary to update connection state before calling > > apr_brigade_cleanup ? > > Is the problem fixed if you reverse the order of > > apr_brigade_cleanup(bb); > > and > > c->aborted = 1; yes, that's right. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
