https://bz.apache.org/bugzilla/show_bug.cgi?id=63288
--- Comment #7 from Yann Ylavic <[email protected]> --- > Nice work! Thanks! > > Is it safe to change the signature of cache_strqtok()? It doesn't have the > ap_prefix, but it also isn't static. Might it be used by third party cache > modules? If so, we could add this as a new function in parallel to the > existing one. No need, cache_strqtok() is not in our API contract (cache_util.h is private, i.e. not installed and nothing AP_DECLARE()d in there). One may forward declare and use it since it's not static, but at his/her own risk; like here :) > > Meanwhile, I will try to get my laptop test setup working again. We could > ask Mark Nottingham to run his test suite against a public-accessible server. If needed we can possibly run a proxy somewhere (I suppose Mark needs to control both the client and the origin/server), but it's probably easier for him to build 2.4.x with this patch than having to coordonate on the origin's URI.. I made some minimal/manual tests already, but Mark's full tests suite is certainly more interesting. Regarding the httpd test framework, mod_cache tests look very minimal as of now, and I'm not sure where to start to add such tests (my perl foo and knowledge of the framework's internals are quite limited :/ ). Possibly we could integrate Mark's easy enough? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
