https://bz.apache.org/bugzilla/show_bug.cgi?id=63900
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |REMIND --- Comment #2 from [email protected] --- (In reply to Christophe JAILLET from comment #1) > Hi, > > The line above is: > status = ap_mpm_query(AP_MPMQ_IS_ASYNC, &async_mpm); > > > As said in the comment: "some MPMs do not implement this", so if an "error" > is reported by a MPM, we consider that it can not process async connections. > > The call chain is: > ap_mpm_query > --> ap_run_mpm_query > --> function defined by 'ap_hook_mpm_query' in each MPM > > Theses functions return in rv, either APR_SUCCESS or APR_ENOTIMPL. > So it is not really an error. > > For example,: > worker_query: rv = APR_ENOTIMPL > event_query: rv = APR_SUCCESS > > > So, this is not strictly speaking error handling, but fallback to a default > behavior if a functionality is not explicitly supported. Understood. But I would suggest tp preserve APR_ENOTIMPL rather than to translate it to APR_SUCCESS to represent the default behavior. If more error codes have been implemented in the ap_run_mpm_query function, simply ignoring such errors can be potentially harmful. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
