https://bz.apache.org/bugzilla/show_bug.cgi?id=63626
--- Comment #12 from Michael Osipov <[email protected]> --- (In reply to Yann Ylavic from comment #10) > Comment on attachment 36700 [details] > Patch for timeouts > > From your patch.. > > >diff --git a/modules/proxy/mod_proxy_http.c b/modules/proxy/mod_proxy_http.c > >index ec1e042c4e..6667931efd 100644 > >--- a/modules/proxy/mod_proxy_http.c > >+++ b/modules/proxy/mod_proxy_http.c > [...] > >@@ -1314,7 +1314,7 @@ int ap_proxy_http_process_response(proxy_http_req_t > >*req) > > " failed.", > > backend->hostname, backend->port); > > } > >- return ap_proxyerror(r, HTTP_BAD_GATEWAY, > >+ return ap_proxyerror(r, HTTP_GATEWAY_TIME_OUT, > > "Error reading from remote server"); > > } > > /* XXX: Is this a real headers length send from remote? */ > > That hunk should probably be: > + return ap_proxyerror(r, APR_STATUS_IS_TIMEUP(rc) > + ? HTTP_GATEWAY_TIME_OUT > + : HTTP_BAD_GATEWAY, > "Error reading from remote server"); > because 504 is not always relevent here, I think. > > The you could differentiate between "{502,503,504} Proxy Error..." in > AH00898. Sorry for responding so late. I agree, this should be generalized. Patch has been updated. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
