https://bz.apache.org/bugzilla/show_bug.cgi?id=64665
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW --- Comment #3 from [email protected] --- (In reply to Christophe JAILLET from comment #1) > Hi, > > I don't get your point. > > The first opens a file for writing, and create it if needed. > If it fails, it logs something. > > The 2nd one checks if a directory already exists. > If not, it logs something. > For me, this is NOT a "file cannot be opened" or created check. > > > Could you elaborate, or even propose a patch of what you think would be > better, to help us understand? Sure, you are right about their functionalities. My point is about their handling of similar errors should be consistent, i.e., In the case of failing to open file/directory, it should consistently handle similar errors by returning!OK or DONE, rather than have different levels of errors. To me, !OK or DECLINED will be better to unify these similar errors, since common error code APR_INCOMPLETE returned by both functions. More specifically, the first function name is ap_open_logs, which suggests its key function is to open logs. So if it fails, !OK or something like DECLINED would better express the current condition. It is worth mentioning that changing DONE to !OK is totally safe. Only three other places invoke this function and check it with != OK. To this end, I would like to propose a patch here. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
