https://bz.apache.org/bugzilla/show_bug.cgi?id=65287
Bug ID: 65287
Summary: balance-manager app produces bad html - no space
between attributes
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_proxy_balancer
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: ---
The internal balance-manager app produces HTML with no space between a couple
of attributes. This occurs in 4 lines in modules/proxy/mod_proxy_balancer.c
starting around line (current) line 1804.
Currently:
ap_rprintf(r, "<tr><td>Interval (ms)</td><td><input name='w_hi' id='w_hi'
type='text'"
"value='%" APR_TIME_T_FMT "'></td></tr>\n",
apr_time_as_msec(wsel->s->interval));
ap_rprintf(r, "<tr><td>Passes trigger</td><td><input name='w_hp' id='w_hp'
type='text'"
"value='%d'></td></tr>\n", wsel->s->passes);
ap_rprintf(r, "<tr><td>Fails trigger)</td><td><input name='w_hf' id='w_hf'
type='text'"
"value='%d'></td></tr>\n", wsel->s->fails);
ap_rprintf(r, "<tr><td>HC uri</td><td><input name='w_hu' id='w_hu' type='text'"
"value=\"%s\"></td></tr>\n", ap_escape_html(r->pool,
wsel->s->hcuri));
The trailing "type='text'" bumps into the next lines' leading "value=".
Suggested fix (which also removes some unneeded single quotes) adds a space
after type=text:
ap_rprintf(r, "<tr><td>Interval (ms)</td><td><input name=w_hi id=w_hi type=text
"
"value='%" APR_TIME_T_FMT "'></td></tr>\n",
apr_time_as_msec(wsel->s->interval));
ap_rprintf(r, "<tr><td>Passes trigger</td><td><input name=w_hp id=w_hp
type=text "
"value='%d'></td></tr>\n", wsel->s->passes);
ap_rprintf(r, "<tr><td>Fails trigger)</td><td><input name=w_hf id=w_hf
type=text "
"value='%d'></td></tr>\n", wsel->s->fails);
ap_rprintf(r, "<tr><td>HC uri</td><td><input name=w_hu id=w_hu type=text "
"value=\"%s\"></td></tr>\n", ap_escape_html(r->pool,
wsel->s->hcuri));
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
