On Mon, Mar 28, 2011 at 11:55:01AM -0600, Jacob Meuser wrote:

>  > @@ -784,7 +784,12 @@
>  >                 if (err) {
>  >                         while (--ifcidx >= 0)
>  >                                 usbd_free_iface_data(dev, ifcidx);
>  > -                       goto bad;
>  > +                       free(dev->ifaces, M_USB);
>  > +                       free(dev->cdesc, M_USB);
>  > +                       dev->ifaces = NULL;
>  > +                       dev->cdesc = NULL;
>  > +                       dev->config = USB_UNCONFIG_NO;
>  > +                       return (err);
>  >                 }
>  >         }
>  > 
>  
>  
>  doesn't this now miss 'free(cdp)'?  and why 'free(dev->ifaces)'?  that was
                                                ^^^^^^^^^^^^^^^^^
>  not allocated here.

sorry, I meant dev->cdesc.  and I see now dev->cdesc == cdp.

thanks for the patch.

-- 
[email protected]
SDF Public Access UNIX System - http://sdf.lonestar.org

Reply via email to