Stuart Henderson schrieb:
On 2011/06/23 11:59, Rechner-Tester wrote:
Hi


The vr(4) man page is missing a note about vlan support.
Vlan support was added as of OpenBSD 4.3:

Add VLAN reception support to vr(4).
<http://openbsd.org/plus43.html>

We don't list vlan support on the manpage for each driver.

I didn't knew that. Sorry.


However there are other changes that should be mentioned.
Rx checksum offload support was added,

Is this usefully at all on the VT6105M?
There was a very interesting analysis of the offloading capabilities of this chip by Willy Tarreau for the Linux module. Have a look at <http://lkml.org/lkml/2007/12/30/242> for details.


and the longword-alignment
mentioned in BUGS is no longer required on the current chips,

That's good to know.


it seems simplest to remove BUGS completely but we could
alternatively keep it and discuss which chips are affected.

I feel uncomfortable dismissing some Information which could still be useful for someone. Since I can not help with the technical details about the affected chips, I suggest to simply change the first sentence as following:

For some older chips the driver always copies transmit mbuf chains into longword-aligned

(Im sorry that I don't know how to create a patch)

Best regards




comments/oks?

Index: vr.4
===================================================================
RCS file: /cvs/src/share/man/man4/vr.4,v
retrieving revision 1.25
diff -u -p -r1.25 vr.4
--- vr.4        13 Mar 2011 21:32:29 -0000      1.25
+++ vr.4        23 Jun 2011 13:46:05 -0000
@@ -61,6 +61,8 @@ and that transmit and receive DMA buffer
  The Rhine chips are meant to be interfaced with external
  physical layer devices via an MII bus.
  They support both 10 and 100Mbps speeds in either full or half duplex.
+IPv4 IP/TCP/UDP receive checksum offload is supported on the VT6105M
+controller.
  .Pp
  The
  .Nm
@@ -178,14 +180,3 @@ The
  .Nm
  driver was written by
  .An Bill Paul Aq [email protected] .
-.Sh BUGS
-The
-.Nm
-driver always copies transmit mbuf chains into longword-aligned
-buffers prior to transmission in order to pacify the Rhine chips.
-If buffers are not aligned correctly, the chip will round the
-supplied buffer address and begin DMAing from the wrong location.
-This buffer copying impairs transmit performance on slower systems but can't
-be avoided.
-On faster machines (e.g., a Pentium II), the performance
-impact is much less noticeable.

Reply via email to