On Sun, May 05, 2013 at 12:15:43AM +0200, Dimitri Sokolyuk wrote:
> >Synopsis: sndiod(1) regression, Segmentation Fault on recorging
> >Category: system
> >Environment:
> System : OpenBSD 5.3
> Details : OpenBSD 5.3 (GENERIC.MP) #62: Tue Mar 12 18:21:20 MDT
> 2013
> [email protected]:
> /usr/src/sys/arch/amd64/compile/GENERIC.MP
>
> Architecture: OpenBSD.amd64
> Machine : amd64
> >Description:
> sndiod(1) dies with Segmentation Fault on data recording.
> The bug was introduced in 5.3 release. The crash occurs on line 628
> of dsp.c
> >How-To-Repeat:
> Run minimal example below.
Thanks for the report and the test program. It should be fixed in
-current (in dev.c rev 1.5). The diff below applies to 5.3 as well.
FWIW, there weren't audio related api changes, so it's safe to
build libsndio and sndiod from -current sources on 5.3.
-- Alexandre
Index: dev.c
===================================================================
RCS file: /var/anoncvs/sndio/sndio/sndiod/dev.c,v
retrieving revision 1.41
diff -u -p -r1.41 dev.c
--- dev.c 26 Feb 2013 11:18:41 -0000 1.41
+++ dev.c 5 May 2013 09:15:46 -0000
@@ -1574,6 +1574,7 @@ found:
s->dup = 0;
s->appbufsz = d->bufsz;
s->round = d->round;
+ s->rate = d->rate;
dev_midi_slotdesc(d, s);
dev_midi_vol(d, s);
return s;
