On Tue, Apr 8, 2014 at 12:13 AM, Ted Unangst <[email protected]> wrote: > Indeed. That's my fault. A side effect of the out of bounds bug was > that a byte of key material wasn't being copied out.
True. > Here's a diff that fixes both issues. As a result of this change, > certain (odd) key strides will behave differently now, and generate > different keys. I don't think these were used in practice. ssh uses an > even stride. The fix looks good to me. I have verified that it gives the same result as the Go implementation I've been working on (which helped found the bug): https://github.com/dchest/bcrypt_pbkdf Thank you! -- Dmitry Chestnykh Coding Robots http://www.codingrobots.com
