On Mon, 01 Dec 2014 08:38:26 +0100, Otto Moerbeek wrote:

> - I could not convince myself that j + from[k] in the k loop 
>   is properly bounded.

Isn't this exactly what the previous loop to set maxtable is for?
The only unbounded access I could find was the ++lowzero loop.

> - The change is (partly) also in byacc

That's not very convincing :-)

> - Somehow i like having a -1 sentinel better than checking a bound.

Fair enough.  I prefer the other check but it's not a huge deal.
I've run yacc through the llvm analyzer which found some potential
issues.  I'll send a diff soon to address those.

 - todd

Reply via email to