On Mon, Jan 19, 2015 at 4:12 AM, Theo de Raadt <[email protected]>
wrote:
> These "smallify" options exist to fit programs onto the media. For many
> programs, it is understood that the on-media command won't work 100% the
> same as the regular one.
>
> But really. This diff makes the original unreadable and unauditable. It
> goes far beyond the purpose.
>
> If we agree to let you do it here, you (or others) are likely to start a
> crusade to apply the same principle for all these cases.
>
> Maybe we can fit more options onto the media. I will try to look into
> that, if a solid usage case exists.
>
Fair enough. I have included a much smaller patch to only deal with
prototype consistency issue.
I do not know a "solid usage case" for including the additional options.
Perhaps the verification logic in install.sub could be made simpler?
My personal usage case would also benefit from it, but I suspect I am doing
unsupported things, so I will not be bothering you with it.
--- md5.c
+++ md5.c
@@ -174,9 +174,9 @@ TAILQ_HEAD(hash_list, hash_function);
void digest_end(const struct hash_function *, void *, char *, size_t, int);
int digest_file(const char *, struct hash_list *, int);
-int digest_filelist(const char *, struct hash_function *, int, char **);
void digest_print(const struct hash_function *, const char *, const char *);
#if !defined(SHA2_ONLY)
+int digest_filelist(const char *, struct hash_function *, int, char **);
void digest_printstr(const struct hash_function *, const char *, const char *);
void digest_string(char *, struct hash_list *);
void digest_test(struct hash_list *);
@@ -442,6 +442,7 @@ digest_print(const struct hash_function *hf, const cha
}
}
+#if !defined(SHA2_ONLY)
void
digest_printstr(const struct hash_function *hf, const char *what,
const char *digest)
@@ -458,6 +459,7 @@ digest_printstr(const struct hash_function *hf, const
break;
}
}
+#endif /* !defined(SHA2_ONLY) */
int
digest_file(const char *file, struct hash_list *hl, int echo)
