On 12/03/15(Thu) 09:53, Henk Jan Agteresch wrote:
> On Tue, 10 Mar 2015, Martin Pieuchot wrote:
>
> >
> > Here's a first diff that should prevent the stack smashing. Could you
> > run with it and tell me if the ARP entry gets overwritten as in 5.5?
> >
>
> Patch works for me. Arp entry gets overwritten. No more panics during
> network configuring.
>
> # dmesg |grep arp
> arpresolve: 213.154.229.23: incorrect arp information
> arpresolve: 213.154.229.23: incorrect arp information
> arpresolve: 213.154.229.23: incorrect arp information
> arpresolve: 213.154.229.23: incorrect arp information
> arpresolve: 213.154.229.23: incorrect arp information
> arp info overwritten for 213.154.229.23 by fe:54:00:b2:8c:98 on pcn0
Could you tell me if the diff below let you use your configuration and
remove the "incorrect arp information" messages?
Index: route.c
===================================================================
RCS file: /cvs/src/sbin/route/route.c,v
retrieving revision 1.172
diff -u -p -r1.172 route.c
--- route.c 6 Feb 2015 03:22:00 -0000 1.172
+++ route.c 17 Mar 2015 17:50:04 -0000
@@ -896,8 +896,8 @@ getaddr(int which, char *s, struct hoste
}
case AF_LINK:
- su->sa.sa_len = sizeof(struct sockaddr_dl);
- link_addr(s, &su->sdl);
+ su->sdl.sdl_index = if_nametoindex(s);
+ memset(&su->sdl.sdl_data, 0, sizeof(su->sdl.sdl_data));
return (1);
case AF_MPLS:
errx(1, "mpls labels require -in or -out switch");
