On 2016/01/08 14:04, Lauri Tirkkonen wrote: > On Wed, Dec 30 2015 11:26:48 +0200, Lauri Tirkkonen wrote: > > >Synopsis: ftp(1) fails when HTTP redirected to a relative URI containing > > >the string "://" > > > >Fix: > > Patch attached. > > No takers?
The problem is valid, but the diff doesn't go far enough, it needs an additional check to avoid breaking currently-working cases. Before patching: $ ftp -Mo- https://junkpile.org/redir-to-colon Trying 195.95.187.26... Requesting https://junkpile.org/redir-to-colon Redirected to https://junkpile.org/test:file.txt Trying 195.95.187.26... Requesting https://junkpile.org/test:file.txt testing... 11 bytes received in 0.00 seconds (44.02 KB/s) After: $ obj/ftp -Mo- https://junkpile.org/redir-to-colon Trying 195.95.187.26... Requesting https://junkpile.org/redir-to-colon Redirected to test:file.txt ftp: url_get: Invalid URL 'test:file.txt' This is a contrived test, but there are definitely URLs in the wild containing : and it wouldn't be entirely unexpected to see a relative redirect to them.
