On Sat, May 28, 2016 at 12:30:45PM +0200, Theo Buehler wrote:
> On Fri, May 27, 2016 at 04:18:48PM +0200, David Coppa wrote:
> > 
> > Fallback code could be removed with no (imho) dramatic consequences.
> 
> That seems to be enough to fix the present issue, but there is still
> this part at the start of _xcb_open():
> 
>     if ((!protocol || (strcmp("unix",protocol) != 0)) &&
>         (*host != '\0') && (strcmp("unix",host) != 0))
>     {
>         /* display specifies TCP */
>         unsigned short port = X_TCP_PORT + display;
>         return _xcb_open_tcp(host, protocol, port);
>     }
> 
> Can't this also be triggered in some circumstances in Carlin's codepath?
> Unfortunately, I don't know my way around X well enough to make this
> happen.
> 

If i3 was connected to an X server over TCP instead of a unix socket it
would hit that codepath when it tries to reconnect.


--
Carlin

Reply via email to