On Wed, Jun 22, 2016 at 09:34:08PM +1200, Carlin Bingham wrote: > I've seen fatal iwm firmware errors the last couple of days, that I > think coincide with this going in, although I can't figure out how to > reproduce it to see if backing this out makes them go away. Just seems > to happen randomly.
Unless you can clearly show that these errors are related to that commit, I'm going to file this as a different problem. There are many situations where the firmware errors out, and we have certainly not fixed all of them (if that's even possible in a lifetime...) The code path which was changed by the commit is only taken while the device is brought up. From the timestamps of the messages you provided it looks as if the firmware error is not happening during association, but much later. A kernel compiled with IWM_DEBUG (add "#define IWM_DEBUG" before the line "#ifdef IWM_DEBUG" in sys/dev/pci/if_iwm.c) may shed more light on the nature of the firmware error. However, in most cases, I cannot tell what's wrong just by looking at a firmware error dump. A reproducible test case makes it much more likely that the problem can be fixed after some experimentation. > Jun 21 17:14:46 vorpal /bsd: iwm0: sending action to 20:cf:30:c6:36:f7 on > channel 3 mode 11n > Jun 21 17:14:46 vorpal /bsd: iwm0: received action from 20:cf:30:c6:36:f7 > rssi 59 mode 11n > Jun 21 17:14:48 vorpal /bsd: iwm0: sending action to 20:cf:30:c6:36:f7 on > channel 3 mode 11n > Jun 21 17:14:48 vorpal /bsd: iwm0: received action from 20:cf:30:c6:36:f7 > rssi 65 mode 11n > Jun 21 17:27:09 vorpal /bsd: iwm0: fatal firmware error > [...] > Jun 22 15:14:15 vorpal /bsd: iwm0: sending action to 20:cf:30:c6:36:f7 on > channel 3 mode 11n > Jun 22 15:14:15 vorpal /bsd: iwm0: received action from 20:cf:30:c6:36:f7 > rssi 61 mode 11n > Jun 22 15:16:31 vorpal /bsd: iwm0: received action from 20:cf:30:c6:36:f7 > rssi 62 mode 11n > Jun 22 15:16:31 vorpal /bsd: iwm0: sending action to 20:cf:30:c6:36:f7 on > channel 3 mode 11n > Jun 22 15:16:31 vorpal /bsd: iwm0: received action from 20:cf:30:c6:36:f7 > rssi 64 mode 11n > Jun 22 15:36:06 vorpal /bsd: iwm0: fatal firmware error > > > This is a Thinkpad T440p with AC 7260
